Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
M MobbScan_UnattendedPlugin-iOS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 1
    • Merge requests 1
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • MobbScan
  • MobbScan_UnattendedPlugin-iOS
  • Merge requests
  • !2

Merged
Created Apr 23, 2020 by Maria Luz Mateo Moreno@mlmateoMaintainer1 of 13 tasks completed1/13 tasks

Features: MOBBSCAN-2839 and MOBBSCAN-2773

  • Overview 1
  • Commits 4
  • Changes 34

Features: MOBBSCAN-2839 and MOBBSCAN-2773

🎯 Summary

This MR fixes localization issues.

⚙ Configuration

Workspace branch: feature/MOBBSCAN-2839

🤔 Type

  • ✨ New feature
  • 🐛 Bug fix
  • 👷 Technical debt
  • ☢️ Breaking change (it breaks backward compatibility)
  • 📚 Requires a change in the docs

⚗️ Solution

The plugin strings are properly localized in default UIs and they can be overridden in final app. Also, the resource manager is fixed to check for string keys in SDK in order to avoid duplicity. The key for the strings are unified with ANDROID. Housekeeping: old target is deleted, references cleanup, remove unused files.

  • 🔗 JIRA: https://issues.mobbeel.com/browse/MOBBSCAN-2839
  • 🔗 JIRA: https://issues.mobbeel.com/browse/MOBBSCAN-2773

🔬 Tests

Messages on default UIs should be localized properly.

🧐 Checklist:

  • The code follow the project guidelines.
  • The changes have been tested locally.
  • The code has internal docs.
  • Docs are updated (README, public docs, etc.)
  • Some tests have been added to check that the changes work as expected (unit, integration or e2e tests ...)
  • Unit tests are running without errors.
  • Other dependant changes have already been merged.
  • Changelog updated (if it applies)
Edited Apr 23, 2020 by Maria Luz Mateo Moreno
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feature/MOBBSCAN-2839