Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L lebara-onboarding-frontend
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 4
    • Merge requests 4
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • MobbScan-Integration
  • Lebara-Video
  • lebara-onboarding-frontend
  • Merge requests
  • !9

Merged
Created May 08, 2020 by César Suárez@csuarez👽Owner2 of 2 tasks completed2/2 tasks

[LEBV-55] Check opening hours, pin and puk in the backend

  • Overview 8
  • Commits 21
  • Changes 26

🎯 Summary

This MR integrates two things:

  • The opening hours which comes from the backend. It should behave like !6 (merged)
  • Phone/PUK validation in the backend side.

🧪 How to test

Start as usual the front, but also the backend should be run in local. Instructions:

  • Check that Docker is installed in your computer.
  • Clone this repo in a new terminal if you don't have it: https://gitlab.mobbeel.com/MobbScan-Integration/lebara-video/lebara-video-deployment
  • In a new terminal, go to the previous project folder in the terminal:
    • git checkout develop
    • git pull
    • docker login (enter your LDAP credentials, only needed the first time)
    • ./sh pull_latest_images.sh
    • docker-compose up

About opening hours

Opening hours cannot be modified since they come from the backend, just check that they are being shown.

About PUK/Phone validations

Now they should be checked with the backend. Valid combination:

  • Phone: 015166804081
  • PUK: 1839

Also, now the frontend validates that the phone starts by 015.

🧠 Considerations

N/A

🧐 Checklist

  • Changes work in Google Chrome
  • Changes work in Safari
  • [-] UI is responsive
Edited May 12, 2020 by César Suárez
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: LEBV-55-opening-hours-endpoint