Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L lebara-onboarding-frontend
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 4
    • Merge requests 4
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • MobbScan-Integration
  • Lebara-Video
  • lebara-onboarding-frontend
  • Merge requests
  • !4

Merged
Created Apr 23, 2020 by César Suárez@csuarez👽Owner3 of 3 tasks completed3/3 tasks

[LEBV-11] Add form step to register SIM data

  • Overview 5
  • Commits 26
  • Changes 58

🎯 Summary

image

Also Roboto font has been removed because it is not used and it hits the load time.

In the technical side, ngx-loadable has been introduced to lazily load next steps for performance reasons.

🧪 How to test

Just play around with the form. Expected behaviours:

  • Phone field should be numeric, should contain a zero and its length could be from 10 to 12.
  • PUK should be numberic and its length could be 4 or 8.
  • The terms and condition error is only shown if phone and PUK are valid.
  • You cannot go to next step if all fields are not valid.
  • You can return to the step at any point clicking on Edit and the introduced values will appear again.

🧠 Considerations

  • There are not backend validations to no block the development. 🆕 JIRA ticket: https://issues.mobbeel.com/browse/LEBV-52
  • The load of the data of the URL has not been implemented to make this ticket smaller. 🆕 JIRA ticket: https://issues.mobbeel.com/browse/LEBV-53

🧐 Checklist

  • Changes work in Google Chrome
  • Changes work in Safari
  • UI is responsive
Edited May 01, 2020 by César Suárez
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: LEBV-11-sim-form